Skip to content

[3.10] bpo-47089: Avoid test_compileall failures on Windows (GH-32037)#32237

Merged
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-76b8a07-3.10
Apr 1, 2022
Merged

[3.10] bpo-47089: Avoid test_compileall failures on Windows (GH-32037)#32237
miss-islington merged 1 commit into
python:3.10from
miss-islington:backport-76b8a07-3.10

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 1, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

(cherry picked from commit 76b8a07)

Co-authored-by: Jeremy Kloth jeremy.kloth@gmail.com

https://bugs.python.org/issue47089

@jkloth @miss-islington
bpo-47089: Avoid test_compileall failures on Windows (pythonGH-32037)
3563222 
(cherry picked from commit 76b8a07)

Co-authored-by: Jeremy Kloth <jeremy.kloth@gmail.com>
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Apr 1, 2022
@bedevere-bot bedevere-bot mentioned this pull request Apr 1, 2022
Merged
@miss-islington

miss-islington commented Apr 1, 2022

Copy link
Copy Markdown
Contributor Author

@jkloth and @vstinner: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes Apr 1, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington

miss-islington commented Apr 1, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: 3 of 6 required status checks are expected..

@jkloth

jkloth commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

Appears the buildbot master is down

@miss-islington

miss-islington commented Apr 1, 2022

Copy link
Copy Markdown
Contributor Author

@jkloth and @vstinner: Status check is done, and it's a failure ❌ .

@vstinner

vstinner commented Apr 1, 2022

Copy link
Copy Markdown
Member

Tests / Ubuntu (pull_request) Failing after 11m — Ubuntu

1 test altered the execution environment: test_asyncio

I re-run the failed job.

Appears the buildbot master is down

Well, it should not block PRs to be merged ;-)

@miss-islington

miss-islington commented Apr 1, 2022

Copy link
Copy Markdown
Contributor Author

@jkloth and @vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 1069d52 into python:3.10 Apr 1, 2022
@miss-islington miss-islington deleted the backport-76b8a07-3.10 branch April 1, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @jkloth @vstinner @the-knights-who-say-ni @bedevere-bot