bpo-28182: Expose OpenSSL verification results#3412
Merged
Conversation
tiran
force-pushed
the
bpo-28182-ssl-error-result
branch
3 times, most recently
from
0a22a60 to
da8bd7b
Compare
zooba
reviewed
Sep 7, 2017
Member
There was a problem hiding this comment.
PyTuple_Pack does not incref elements, but Py_DECREF(bases) will. Should probably avoid that here (Py_BuildValue("OO", ...) will incref)
The SSL module now raises SSLCertVerificationError when OpenSSL fails to verify the peer's certificate. The exception contains more information about the error. Original patch by Chi Hsuan Yen Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-28182-ssl-error-result
branch
from
da8bd7b to
f794f8e
Compare
zooba
approved these changes
Sep 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSL module now raises SSLCertVerificationError when OpenSSL fails to
verify the peer's certificate. The exception contains more information about
the error.
Original patch by Chi Hsuan Yen
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue28182