Skip to content

bpo-31634: Install wheel in ensurepip#3818

Closed
segevfiner wants to merge 3 commits into
python:masterfrom
segevfiner:bpo-31634-ensurepip-wheel
Closed

bpo-31634: Install wheel in ensurepip#3818
segevfiner wants to merge 3 commits into
python:masterfrom
segevfiner:bpo-31634-ensurepip-wheel

Conversation

@segevfiner

@segevfiner segevfiner commented Sep 29, 2017

Copy link
Copy Markdown
Contributor

@segevfiner segevfiner force-pushed the bpo-31634-ensurepip-wheel branch from 1f60bd3 to 982cc2c Compare September 29, 2017 10:09
@merwok

merwok commented Oct 3, 2017

Copy link
Copy Markdown
Member

Can you update the reST docs?

@segevfiner segevfiner force-pushed the bpo-31634-ensurepip-wheel branch from 006682e to dfc9f13 Compare October 4, 2017 09:00
@segevfiner

Copy link
Copy Markdown
Contributor Author

@merwok I added a clause to whatsnew/3.7.rst. ensurepip.rst seems to explicitly not mention the dependencies it installs for pip (Before this PR, this was only setuptools), so I didn't change it.

@merwok merwok requested review from dstufft and ncoghlan October 4, 2017 18:28
@merwok

merwok commented Oct 4, 2017

Copy link
Copy Markdown
Member

Ok I’ll let @ncoghlan say if these should be implementation details or advertised features.

@dstufft

dstufft commented Oct 4, 2017

Copy link
Copy Markdown
Member

What packages (other then pip) this installs is an implementation detail. The intent was that once pip is able to automatically install setuptools/etc as part of building a sdist, that ensurepip would no longer ship setuptools by default, and it would only install pip.

@ncoghlan

ncoghlan commented Oct 5, 2017

Copy link
Copy Markdown
Contributor

Thanks for the PR! As @dstufft noted, the fact ensurepip installs even setuptools as a dependency is currently considered an implementation detail, and is likely to be replaced at some point by having pip itself dynamically install it when asked to build from a source archive (at which point pip would install both setuptools and wheel).

So I'm going to close this PR without merging it, but I've closed the related issue as "postponed" rather than "rejected", as there other reasons we may end up offering an ensuresetuptools module that bundles both setuptools and wheel: https://bugs.python.org/issue31634#msg303734

@ncoghlan ncoghlan closed this Oct 5, 2017
@segevfiner segevfiner deleted the bpo-31634-ensurepip-wheel branch October 5, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants