Skip to content

bpo-31678 Fix datetime.timedelta C function name in API documentation#3869

Merged
berkerpeksag merged 1 commit into
python:masterfrom
Phobosmir:fix-datetime.timedelta-doc
Nov 4, 2017
Merged

bpo-31678 Fix datetime.timedelta C function name in API documentation#3869
berkerpeksag merged 1 commit into
python:masterfrom
Phobosmir:fix-datetime.timedelta-doc

Conversation

@Phobosmir

@Phobosmir Phobosmir commented Oct 3, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Fixed C function name for datetime.timedelta.

https://bugs.python.org/issue31678

https://bugs.python.org/issue31678

@the-knights-who-say-ni

the-knights-who-say-ni commented Oct 3, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@merwok merwok changed the title Fixed datetime.timedelta C function name in API documentation bpo-31678 Fix datetime.timedelta C function name in API documentation Oct 3, 2017
@berkerpeksag berkerpeksag merged commit 82cd3ce into python:master Nov 4, 2017
@miss-islington

miss-islington commented Nov 4, 2017

Copy link
Copy Markdown
Contributor

Thanks @Phobosmir for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@berkerpeksag

berkerpeksag commented Nov 4, 2017

Copy link
Copy Markdown
Member

Thanks!

@bedevere-bot

bedevere-bot commented Nov 4, 2017

Copy link
Copy Markdown

GH-4274 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 4, 2017
@Phobosmir @miss-islington
bpo-31678: Fix typo in PyDateTime_DELTA_GET_MICROSECONDS (pythonGH-3869)
84ac9de 
(cherry picked from commit 82cd3ce)
berkerpeksag pushed a commit that referenced this pull request Nov 4, 2017
@miss-islington @berkerpeksag
bpo-31678: Fix typo in PyDateTime_DELTA_GET_MICROSECONDS (GH-3869)
f938746 
(cherry picked from commit 82cd3ce)
embray pushed a commit to embray/cpython that referenced this pull request Nov 9, 2017
@Phobosmir @embray
bpo-31678: Fix typo in PyDateTime_DELTA_GET_MICROSECONDS (pythonGH-3869)
accf060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Phobosmir @the-knights-who-say-ni @miss-islington @berkerpeksag @bedevere-bot @merwok