Skip to content

bpo-31961: subprocess.run() now accepts path-like args #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 8 commits into from
Jan 30, 2018
Merged

bpo-31961: subprocess.run() now accepts path-like args #4329

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
59413e7
Added a failing test and the fix for it on non-windows
Phaqui Nov 7, 2017
e348a0c
Implemented windows test and fix
Phaqui Nov 8, 2017
79b6da8
Updated documentation for subprocess.Popen to reflect that it now wor…
Phaqui Nov 8, 2017
a65bf70
Added NEWS.d/next/ entry
Phaqui Nov 8, 2017
42c06a2
Updated second test slightly
Phaqui Nov 8, 2017
b444e40
Simplified pathlike_with_arguments test
Phaqui Nov 8, 2017
efffc2a
add comments to the new os.PathLike logic
gpshead Jan 30, 2018
b70c0ae
Merge branch 'master' into fix-issue-31961
gpshead Jan 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplified pathlike_with_arguments test
  • Loading branch information
@Phaqui
Phaqui committed Nov 8, 2017
commit b444e401c6c1c17bc8a63bf4cb8af658bbce52d9
7 changes: 2 additions & 5 deletions Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,12 +1501,9 @@ def __fspath__(self):
return sys.executable

path = Path()
args = [path, '-c', 'import sys; sys.exit(57)']

if mswindows:
res = subprocess.run(args)
else:
res = subprocess.run(args)
args = [path, '-c', 'import sys; sys.exit(57)']
res = subprocess.run(args)

self.assertEqual(res.returncode, 57)

Expand Down