Remove redundant 'exc = True' line#4357
Merged
Merged
Conversation
It can be removed after python/peps@c28890f
serhiy-storchaka
approved these changes
Nov 11, 2017
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM.
After merging try...except and try...finally in try...exept...else the exc flag no longer needed.
The same change should be made in PEP 492 (if this is not done yet).
Member
Author
Done in python/peps@cd78f23. |
Contributor
|
Thanks @berkerpeksag for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 11, 2017
It can be removed after python/peps@c28890f (cherry picked from commit 7c9da3e)
|
GH-4372 is a backport of this pull request to the 3.6 branch. |
berkerpeksag
pushed a commit
that referenced
this pull request
Nov 11, 2017
It can be removed after python/peps@c28890f (cherry picked from commit 7c9da3e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be removed after python/peps@c28890f