bpo-25910: Fixes redirection from http to https by CuriousLearner · Pull Request #4674 · python/cpython

CuriousLearner · 2017-12-02T11:38:06Z

This PR extracts changes from #1933

Currently focuses mostly on fixing link redirection from http to https.

https://bugs.python.org/issue25910

vstinner · 2017-12-04T15:55:34Z

-releases, it also offers a number of features via pure Python
-extensions that are not available in other language bindings.  There
-is an active wxPython user and developer community.
+wxPython (https://www.wxpython.org) is the Python binding for wxwidgets.


Would you mind to create a link?

`wxPython <url>`_

vstinner · 2017-12-04T15:56:07Z

-extensions that are not available in other language bindings.  There
-is an active wxPython user and developer community.
+wxPython (https://www.wxpython.org) is the Python binding for wxwidgets.
+While it often lags slightly behind the official wxWidgets releases, it also


@vadmium asked you to not reformat links like this, please restrict this PR to HTTPS.

Apologies for that. I just extracted the same old changes from the earlier patch. I'll fix this.

vstinner · 2017-12-04T15:57:35Z


-See http://cx-freeze.sourceforge.net/ for a distutils extension that allows you
-to create console and GUI executables from Python code.
+See https://anthony-tuininga.github.io/cx_Freeze/ for a distutils extension


Please create a link. You may be able to omit the url here, since it's written in a previous section (check the HTML output, I'm not sure).

`cx_Freeze`_

vstinner · 2017-12-04T16:00:40Z

   You should have received a copy of the CC0 Public Domain Dedication along
   with this software. If not, see
-   http://creativecommons.org/publicdomain/zero/1.0/.
+   https://creativecommons.org/publicdomain/zero/1.0/.


This text is a license. Is it ok to modify a license?

I'm not sure about that. Should I ask this on the bug?

I think it's ok. I take the responsability for this change ;-)

Alright thanks :)

vstinner · 2017-12-04T16:03:45Z

+:mod:`distutils` extension (see :ref:`extending-distutils`) which wraps
+Python scripts into executable Windows programs (:file:`{*}.exe` files).
+When you have done this, you can distribute your application without
+requiring your users to install Python.


Again, please revert this change, only replace the HTTP link.

vstinner · 2017-12-04T16:04:39Z

 tests.  It's not as fancy as `py.test <http://pytest.org>`__ or
-`nose <http://code.google.com/p/python-nose/>`__, but provides a simple way
-to run tests kept within a set of package directories.  For example,
+`nose <https://code.google.com/archive/p/python-nose>`__, but provides a


This link seems undated. The new home is more https://nose.readthedocs.io/ no?

Seems like you're right about it. The make linkcheck command showed me this as a 301. So, I updated it to point to this link.

vstinner · 2017-12-04T16:05:00Z

   Tools that use or will use the new syntax:
-   `mypy <http://github.com/python/mypy>`_,
-   `pytype <http://github.com/google/pytype>`_, PyCharm, etc.
+   `mypy <https://github.com/python/mypy>`_,


The home is more http://www.mypy-lang.org/ no?

bedevere-bot · 2017-12-04T16:05:37Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

CuriousLearner · 2017-12-05T16:28:42Z

I have made the requested changes; please review again

bedevere-bot · 2017-12-05T16:28:44Z

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner

LGTM.

vstinner · 2017-12-06T16:38:37Z

   You should have received a copy of the CC0 Public Domain Dedication along
   with this software. If not, see
-   http://creativecommons.org/publicdomain/zero/1.0/.
+   https://creativecommons.org/publicdomain/zero/1.0/.


I think it's ok. I take the responsability for this change ;-)

vstinner · 2017-12-06T16:39:57Z

Thanks @CuriousLearner, I merged your PR.

CuriousLearner · 2017-12-06T16:49:03Z

Thanks @vstinner.

miss-islington · 2018-05-26T13:20:44Z

Thanks @CuriousLearner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington · 2018-05-26T13:21:54Z

Sorry, @CuriousLearner and @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1b4587a2462fc05a14be87123083322103a1f55b 3.6

ned-deily · 2018-05-26T13:23:13Z

Sorry, please ignore the backport to 3.6 noise!

bpo-25910: Fixes redirection from http to https

afde3fc

CuriousLearner requested a review from a team as a code owner December 2, 2017 11:38

the-knights-who-say-ni added the CLA signed label Dec 2, 2017

bedevere-bot added the awaiting review label Dec 2, 2017

vstinner added the skip news label Dec 4, 2017

vstinner requested changes Dec 4, 2017

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Dec 4, 2017

CuriousLearner added 2 commits December 4, 2017 23:36

Address review comments

2692007

Fixes link to nose.readthedocs.io

46ba671

bedevere-bot added awaiting change review and removed awaiting changes labels Dec 5, 2017

vstinner approved these changes Dec 6, 2017

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Dec 6, 2017

vstinner merged commit 1b4587a into python:master Dec 6, 2017

bedevere-bot removed the awaiting merge label Dec 6, 2017

ned-deily added the needs backport to 3.6 label May 26, 2018

miss-islington assigned vstinner May 26, 2018

ned-deily removed the needs backport to 3.6 label May 26, 2018

ned-deily unassigned vstinner May 26, 2018

JulienPalard mentioned this pull request Jul 3, 2018

Doc: Stackless Python wiki moved to github. #8072

Merged

zitterbewegung mentioned this pull request Apr 24, 2023

Docs for "Using Python on a Macintosh" needs to be updated #56803

Closed

Uh oh!

Conversation

CuriousLearner commented Dec 2, 2017 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bedevere-bot commented Dec 4, 2017

Uh oh!

CuriousLearner commented Dec 5, 2017

Uh oh!

bedevere-bot commented Dec 5, 2017

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vstinner commented Dec 6, 2017

Uh oh!

CuriousLearner commented Dec 6, 2017

Uh oh!

miss-islington commented May 26, 2018

Uh oh!

miss-islington commented May 26, 2018

Uh oh!

ned-deily commented May 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CuriousLearner commented Dec 2, 2017 •

edited by bedevere-bot

Loading