Skip to content

bpo-32098: Fix hardcoded value in test_os.py#4744

Merged
vstinner merged 1 commit into
python:masterfrom
pablogsal:bpo31972
Dec 7, 2017
Merged

bpo-32098: Fix hardcoded value in test_os.py#4744
vstinner merged 1 commit into
python:masterfrom
pablogsal:bpo31972

Conversation

@pablogsal

@pablogsal pablogsal commented Dec 7, 2017

Copy link
Copy Markdown
Member

@merwok

merwok commented Dec 7, 2017

Copy link
Copy Markdown
Member

I think this PR has the wrong bug number.

@pablogsal pablogsal changed the title bpo-31972: Fix hardcoded value in test_os.py bpo-32098: Fix hardcoded value in test_os.py Dec 7, 2017
@pablogsal

Copy link
Copy Markdown
Member Author

Indeed, the correct one is 32098. My bad.

@pablogsal

Copy link
Copy Markdown
Member Author

@merwok Thanks for the catch!

@vstinner vstinner merged commit fb77e0d into python:master Dec 7, 2017
@vstinner

vstinner commented Dec 7, 2017

Copy link
Copy Markdown
Member

Thank you for your contribution ;-)

@vstinner

vstinner commented Dec 7, 2017

Copy link
Copy Markdown
Member

Oops, I missed the fact that the bpo number was missing in the commit message. It's still surprised that the Pull Request title and descript are different than the "generated" commit message when I press [Merge]. Sometimes I forget to check, like for this PR. It doesn't matter, it's a trivial fix.

@pablogsal pablogsal deleted the bpo31972 branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants