Skip to content

bpo-32253: Deprecate with statement and bare await for asyncio locks #4764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 10 commits into from
Dec 9, 2017
Merged

bpo-32253: Deprecate with statement and bare await for asyncio locks #4764

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5855aa5
Add test for with (yield from lock)
asvetlov Dec 9, 2017
ca77820
Deprecate with statement for asyncio locks
asvetlov Dec 9, 2017
db2167b
Document deprecation of with statement for asyncio locks
asvetlov Dec 9, 2017
04e1b8e
Add NEWS entry
asvetlov Dec 9, 2017
694a769
Simplify docs structure for asyncio locks
asvetlov Dec 9, 2017
3159fca
Fix notes
asvetlov Dec 9, 2017
c57bccb
Fix test
asvetlov Dec 9, 2017
a069dd6
Drop redundant lines
asvetlov Dec 9, 2017
2aeb296
Fix text
asvetlov Dec 9, 2017
124a305
Fix notes
asvetlov Dec 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@asvetlov
asvetlov committed Dec 9, 2017
commit c57bccb997022a1d1cbcd738344cd58c3b8e3b31
7 changes: 5 additions & 2 deletions Lib/asyncio/locks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ def __iter__(self):
# <block>
# finally:
# lock.release()
warnings.warn("'with (yield from lock):' is deprecated "
"use 'async with lock:' instead",
warnings.warn("'with (yield from lock)' is deprecated "
"use 'async with lock' instead",
DeprecationWarning, stacklevel=2)
yield from self.acquire()
return _ContextManager(self)
Expand All @@ -75,6 +75,9 @@ async def __acquire_ctx(self):
return _ContextManager(self)

def __await__(self):
warnings.warn("'with await lock' is deprecated "
"use 'async with lock' instead",
DeprecationWarning, stacklevel=2)
# To make "with await lock" work.
return self.__acquire_ctx().__await__()

Expand Down