Skip to content

bpo-29728: Provide socket.TCP_NOTSENT_LOWAT#477

Merged
Mariatta merged 5 commits into
python:masterfrom
njsmith:patch-1
Mar 23, 2017
Merged

bpo-29728: Provide socket.TCP_NOTSENT_LOWAT#477
Mariatta merged 5 commits into
python:masterfrom
njsmith:patch-1

Conversation

@njsmith

@njsmith njsmith commented Mar 5, 2017

Copy link
Copy Markdown
Contributor

New TCP option available on recent MacOS and Linux.

@alex

alex commented Mar 5, 2017

Copy link
Copy Markdown
Member

This should probably be documented in socket.rst

@Mariatta

Mariatta commented Mar 5, 2017

Copy link
Copy Markdown
Member

Please create a ticket in bugs.python.org to track this :)

@njsmith

njsmith commented Mar 5, 2017

Copy link
Copy Markdown
Contributor Author

@alex: good point, done.

@Mariatta: https://bugs.python.org/issue29728

@Mariatta Mariatta changed the title Provide socket.TCP_NOTSENT_LOWAT bpo-29728: Provide socket.TCP_NOTSENT_LOWAT Mar 5, 2017
@Mariatta

Mariatta commented Mar 7, 2017

Copy link
Copy Markdown
Member

@njsmith seems like there's trailing whitespace issue with the docs change 😅

Will you be able to fix it? (see travis output)

@Mariatta

Mariatta commented Mar 7, 2017

Copy link
Copy Markdown
Member

I think this should be added to Misc/NEWS too.

@njsmith

njsmith commented Mar 18, 2017

Copy link
Copy Markdown
Contributor Author

@Mariatta: whoops, I somehow missed the notification on your earlier comments. Thanks for fixing things up!

@Mariatta

Copy link
Copy Markdown
Member

Well... in my attempt to clean this however... I actually messed up your branch 😅 Sorry about this. I will try to clean it up later..

@njsmith

njsmith commented Mar 18, 2017

Copy link
Copy Markdown
Contributor Author

Rebased and cleaned up

@njsmith

njsmith commented Mar 18, 2017

Copy link
Copy Markdown
Contributor Author

no idea what that travis failure is about

@Mariatta

Copy link
Copy Markdown
Member

Thanks @njsmith :)

I think the travis failure is a separate matter, tracked in python/core-workflow#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants