bpo-22671: Fix issue22671 make patchcheck#4818
Closed
CuriousLearner wants to merge 3 commits into
Closed
Conversation
Member
|
I don't understand the purpose of the change. The io doc change was already merged, so this PR is going to conflict no? Most changes are related to indentation. I suggest to reject this PR. Coding style only chnages must be carefully discussed on python-dev. They don't seem to be needed to me. |
Member
Author
|
@vstinner indeed. I ran |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on patch for the issue, I ran
make patchcheckand it fixed indentation in some of the C files. The actual patch has been already committed in PR: #4568cc @vstinner
https://bugs.python.org/issue22671