Skip to content

bpo-32299: unittest.mock.patch.dict now returns patched dict when used as context manager #4834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ts-taiye wants to merge 6 commits into from
Closed

bpo-32299: unittest.mock.patch.dict now returns patched dict when used as context manager #4834

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ed25324
bpo-32299: unittest.patch.dict now returns patched dict when used as …
taiye-ts Dec 13, 2017
6f0040f
bpo-32299: unittest.patch.dict now returns patched dict when used as …
taiye-ts Dec 13, 2017
b5ceb1a
Update 2017-12-13-17-49-56.bpo-32299.eqAPWs.rst
asvetlov Dec 13, 2017
fe3ced7
bpo-32299: unittest.patch.dict now returns patched dict when used as …
taiye-ts Dec 15, 2017
396a6ee
Merge branch 'fix-issue-32299' of https://github.com/ts-taiye/cpython…
taiye-ts Dec 27, 2017
f00a266
bpo-32299: unittest.patch.dict now returns patched dict when used as …
taiye-ts Dec 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bpo-32299: unittest.patch.dict now returns patched dict when used as … 
…context manager
  • Loading branch information
@taiye-ts
taiye-ts committed Dec 29, 2017
commit f00a26671604446eaef3a95885ac38568a906f01
5 changes: 3 additions & 2 deletions Doc/library/unittest.mock.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1275,8 +1275,7 @@ patch.dict

:func:`patch.dict` can be used as a context manager, decorator or class
decorator. When used as a class decorator :func:`patch.dict` honours
``patch.TEST_PREFIX`` for choosing which methods to wrap. When used as a
context manager it returns patched *in_dict*.
``patch.TEST_PREFIX`` for choosing which methods to wrap.

:func:`patch.dict` can be used to add members to a dictionary, or simply let a test
change a dictionary, and ensure the dictionary is restored when the test
Expand Down Expand Up @@ -1333,6 +1332,8 @@ magic methods :meth:`__getitem__`, :meth:`__setitem__`, :meth:`__delitem__` and
>>> assert thing['one'] == 1
>>> assert list(thing) == ['one']

:func:`patch.dict` returns a patched dictionary when used as context manager.

@berkerpeksag berkerpeksag Jan 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be moved after the paragraph that starts with ":func:`patch.dict` can be used as a context manager, [...]".

Also, add a versionchanged marker after that paragraph:

.. versionchanged:: 3.7
   :func:`patch.dict` now returns the patched dictionary when it used as a context manager.

(Feel free to use any wording you want, I just gave an example.)



patch.multiple
~~~~~~~~~~~~~~
Expand Down