Skip to content

bpo-32339: Make csv.DictReader returning regular dict instead of OrderedDict.#4904

Closed
shangdahao wants to merge 1 commit into
python:masterfrom
shangdahao:bpo-32339
Closed

bpo-32339: Make csv.DictReader returning regular dict instead of OrderedDict.#4904
shangdahao wants to merge 1 commit into
python:masterfrom
shangdahao:bpo-32339

Conversation

@shangdahao

@shangdahao shangdahao commented Dec 16, 2017

Copy link
Copy Markdown
Contributor

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@rhettinger

Copy link
Copy Markdown
Contributor

Normally, we would have a deprecation period before switching the return type. Potentially, this patch could break existing code that relied on methods like move_to_end() which are present in OrderedDict() but not in dict().

That said, I think such code is either unlikely or rare, so it would be net less disruptive for users to just go forward with this patch.

Since this would be a break from our usual policies, you would need to get the support of other core-devs before this patch could be applied.

@gvanrossum

Copy link
Copy Markdown
Member

Let's not do this -- see the python-dev thread. It's no big deal anyways.

@shangdahao

Copy link
Copy Markdown
Contributor Author

Thanks rhettinger and gvanrossum, I am going to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants