-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
gh-76534: Added docs about Embedding with an frozen module limitation. #4910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e8067c1
Added docs about Embedding with an frozen module limitation.
AraHaan a6e671b
bpo-32353: Document the fix to the common mistake with frozen modules.
AraHaan 2d57436
bpo-32353: fix whitespace.
AraHaan ef1bf23
bpo-32353: Expand the note with more info.
AraHaan 5d0c47f
bpo-32353: Add news entry.
AraHaan 70cbd9a
bpo-32353: Add yet another note.
AraHaan 2d5d20c
bpo-32353: fix typo.
AraHaan 5a6198c
Update Doc/extending/embedding.rst
AraHaan 959394d
Apply suggestions from code review
AraHaan ff907a0
Apply suggestions from code review
AraHaan 6df7c94
Merge branch 'main' into patch-2
arhadthedev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Documentation/2017-12-19-19-57-41.bpo-32353.cHpGHn.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Added more documentation on manually embedding python with custom frozen | ||
| modules. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by 'bitten'? I think it's better to use direct language and be clear on what the problem might be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in when they try to run it, it won't work properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific exception/error that appears, or does it do something like hang?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it crashes or errors.