Skip to content

[3.6] bpo-15852: correct the typos (GH-4950)#4951

Merged
asvetlov merged 1 commit into
python:3.6from
miss-islington:backport-83cb778-3.6
Dec 21, 2017
Merged

[3.6] bpo-15852: correct the typos (GH-4950)#4951
asvetlov merged 1 commit into
python:3.6from
miss-islington:backport-83cb778-3.6

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 20, 2017

Copy link
Copy Markdown
Contributor

(cherry picked from commit 83cb778)

https://bugs.python.org/issue15852

(cherry picked from commit 83cb778)
@miss-islington

Copy link
Copy Markdown
Contributor Author

@srinivasreddy and @asvetlov: Backport status check is done, and it's a failure ❌ .

@asvetlov asvetlov changed the title [3.6] correct the typos (GH-4950) [3.6] bpo-15852: correct the typos (GH-4950) Dec 21, 2017
@miss-islington

Copy link
Copy Markdown
Contributor Author

@srinivasreddy and @asvetlov: Backport status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@srinivasreddy and @asvetlov: Backport status check is done, and it's a success ✅ .

@asvetlov asvetlov merged commit 020668b into python:3.6 Dec 21, 2017
@miss-islington

Copy link
Copy Markdown
Contributor Author

Thanks, @asvetlov!

@miss-islington miss-islington deleted the backport-83cb778-3.6 branch December 21, 2017 05:43
@srinivasreddy

Copy link
Copy Markdown
Contributor

I think it is a good idea to preserve the title of the PR while back-porting. So we don't need to add it. I would like to contribute the patch to bot, now could you please point to the bot's source code?
@asvetlov

@asvetlov

Copy link
Copy Markdown
Contributor

@Mariatta could describe our infrastructure much better than me.

@Mariatta

Copy link
Copy Markdown
Member

Thanks @srinivasreddy and @asvetlov.
For the backport PR, the title is from the squashed commit message, not from the original PR title., this is by design.

The commit message on master does not have the bpo number, that's why the status check failed.

When merging, the core dev has the opportunity to edit the commit message, and in many cases, they do. So the bot should not be modified at this point. But rather, core devs should make sure the commit message is appropriate :)

Hope this makes sense.

@asvetlov

Copy link
Copy Markdown
Contributor

Thanks for explanation.
Will be more careful about commit messages next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants