-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
bpo-32746: Fix multiple typos #5144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
d7fc123
d64a14a
27cd045
f41d647
4488ade
fd1d61c
f64942f
1f7ea65
94e2783
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -142,7 +142,7 @@ def jabs_op(name, op): | |
| def_op('BUILD_TUPLE', 102) # Number of tuple items | ||
| def_op('BUILD_LIST', 103) # Number of list items | ||
| def_op('BUILD_SET', 104) # Number of set items | ||
| def_op('BUILD_MAP', 105) # Number of dict entries (upto 255) | ||
| def_op('BUILD_MAP', 105) # Number of dict entries (up to 255) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "(up to 255)" is outdated (in 3.6 too). Just remove it.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. elopio or whoever makes the change should refresh the patch against master. |
||
| name_op('LOAD_ATTR', 106) # Index in name list | ||
| def_op('COMPARE_OP', 107) # Comparison operator | ||
| hascompare.append(107) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,7 +20,7 @@ | |
| version: 2.59 | ||
|
|
||
| -- This set of tests primarily tests the existence of the operator. | ||
| -- Additon, subtraction, rounding, and more overflows are tested | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an external source. I would prefer not to maintain our own version, even for typos.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reverted. |
||
| -- Addition, subtraction, rounding, and more overflows are tested | ||
| -- elsewhere. | ||
|
|
||
| precision: 9 | ||
|
|
@@ -158,4 +158,3 @@ absx527 abs -sNaN33 -> -NaN33 Invalid_operation | |
|
|
||
| -- Null tests | ||
| absx900 abs # -> NaN Invalid_operation | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -199,7 +199,7 @@ def loadTestsFromModule(module, pattern=None): | |
| ['a_directory', 'test_directory', 'test_directory2']) | ||
|
|
||
| # load_tests should have been called once with loader, tests and pattern | ||
| # (but there are no tests in our stub module itself, so thats [] at the | ||
| # (but there are no tests in our stub module itself, so that's [] at the | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 'that is' would maybe be even better
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done. |
||
| # time of call. | ||
| self.assertEqual(Module.load_tests_args, | ||
| [(loader, [], 'test*')]) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,21 +2,21 @@ | |
| win32.S - Copyright (c) 1996, 1998, 2001, 2002 Red Hat, Inc. | ||
| Copyright (c) 2001 John Beniton | ||
| Copyright (c) 2002 Ranjit Mathew | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I realize we have our own copy of libffi for Windows. Wouldn't changes to these files cause porting upstream changes more difficult? I suggest we not change any libffi files. See Modules/_ctypes/libffi_osx/README.ctypes.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reverted. |
||
|
|
||
|
|
||
| X86 Foreign Function Interface | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining | ||
| a copy of this software and associated documentation files (the | ||
| ``Software''), to deal in the Software without restriction, including | ||
| without limitation the rights to use, copy, modify, merge, publish, | ||
| distribute, sublicense, and/or sell copies of the Software, and to | ||
| permit persons to whom the Software is furnished to do so, subject to | ||
| the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included | ||
| in all copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED ``AS IS'', WITHOUT WARRANTY OF ANY KIND, EXPRESS | ||
| OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF | ||
| MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. | ||
|
|
@@ -56,7 +56,7 @@ ffi_call_x86(void (* prepfunc)(char *, extended_cif *), /* 8 */ | |
| // Make room for all of the new args. | ||
| mov ecx, [ebp+16] | ||
| sub esp, ecx // sub esp, bytes | ||
|
|
||
| mov eax, esp | ||
|
|
||
| // Place all of the ffi_prep_args in position | ||
|
|
@@ -74,7 +74,7 @@ ffi_call_x86(void (* prepfunc)(char *, extended_cif *), /* 8 */ | |
| mov ecx, [ebp + 12] | ||
| mov ecx, [ecx]ecif.cif | ||
| mov ecx, [ecx]ecif.cif.abi | ||
|
|
||
| cmp ecx, FFI_STDCALL | ||
| je noclean | ||
| // STDCALL: Remove the space we pushed for the args | ||
|
|
@@ -90,7 +90,7 @@ ffi_call_x86(void (* prepfunc)(char *, extended_cif *), /* 8 */ | |
|
|
||
| // If the return value pointer is NULL, assume no return value. | ||
| /* | ||
| Intel asm is weird. We have to explicitely specify 'DWORD PTR' in the nexr instruction, | ||
| Intel asm is weird. We have to explicitly specify 'DWORD PTR' in the nexr instruction, | ||
| otherwise only one BYTE will be compared (instead of a DWORD)! | ||
| */ | ||
| cmp DWORD PTR [ebp + 24], 0 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -650,7 +650,7 @@ ffi_call( | |
| +---------------------------------------+ 160 | ||
| | result area 8 | | ||
| +---------------------------------------+ 168 | ||
| | alignement to the next multiple of 16 | | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment with this file: I realize we have our own copy of libffi for OS-X. Wouldn't changes to these files cause porting upstream changes more difficult? I suggest we not change any libffi files. See Modules/_ctypes/libffi_osx/README.pyobjc.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reverted. |
||
| | alignment to the next multiple of 16 | | ||
| SP current --> +---------------------------------------+ 176 <- parent frame | ||
| | back chain to caller 4 | | ||
| +---------------------------------------+ 180 | ||
|
|
@@ -891,7 +891,7 @@ ffi_closure_helper_DARWIN( | |
| avalue[i] = alloca(arg_types[i]->size); | ||
| ffi64_struct_to_ram_form(arg_types[i], (const char*)pgr, | ||
| &gprSize, (const char*)pfr, &fprSize, &nf, avalue[i], NULL); | ||
|
|
||
| ng += gprSize / sizeof(long); | ||
| pgr += gprSize / sizeof(long); | ||
| pfr += (fprSize - savedFPRSize) / sizeof(double); | ||
|
|
@@ -1479,7 +1479,7 @@ ffi64_struct_to_reg_form( | |
| memcpy(&outGPRs[destGMarker], | ||
| &inStruct[srcMarker], inType->size); | ||
| } | ||
|
|
||
| srcMarker += inType->size; | ||
| destGMarker += inType->size; | ||
| i += inType->size - 1; | ||
|
|
@@ -1561,7 +1561,7 @@ ffi64_struct_to_reg_form( | |
| case FFI_TYPE_STRUCT: | ||
| recurseCount++; | ||
| ffi64_struct_to_reg_form(inType->elements[i], | ||
| inStruct, &srcMarker, &fprsUsed, outGPRs, | ||
| inStruct, &srcMarker, &fprsUsed, outGPRs, | ||
| &destGMarker, outFPRs, &destFMarker); | ||
| recurseCount--; | ||
| break; | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls do not remove existing lines. In other places too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can revert this, but I'm curious, why do you want two empty lines at the bottom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry. I didn't look at the file. If it is at bottom, you can keep it. I am worried about introducing unnecessary git diffs in the middle of a file.