Skip to content

bpo-32311: Drop asyncio.create_task #5244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
asvetlov wants to merge 2 commits into from
Closed

bpo-32311: Drop asyncio.create_task #5244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65641c2
Drop create_task
asvetlov Jan 19, 2018
1e944de
Drop NEWS entry
asvetlov Jan 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions Doc/library/asyncio-task.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,17 +377,6 @@ with the result.
Task
----

.. function:: create_task(coro)

Wrap a :ref:`coroutine <coroutine>` *coro* into a task and schedule
its execution. Return the task object.

The task is executed in :func:`get_running_loop` context,
:exc:`RuntimeError` is raised if there is no running loop in
current thread.

.. versionadded:: 3.7

.. class:: Task(coro, \*, loop=None)

A unit for concurrent running of :ref:`coroutines <coroutine>`,
Expand Down Expand Up @@ -416,7 +405,7 @@ Task
<coroutine>` did not complete. It is probably a bug and a warning is
logged: see :ref:`Pending task destroyed <asyncio-pending-task-destroyed>`.

Don't directly create :class:`Task` instances: use the :func:`create_task`
Don't directly create :class:`Task` instances: use the :func:`ensure_future`
function or the :meth:`AbstractEventLoop.create_task` method.

This class is :ref:`not thread safe <asyncio-multithreading>`.
Expand Down Expand Up @@ -586,15 +575,9 @@ Task functions
.. versionchanged:: 3.5.1
The function accepts any :term:`awaitable` object.

.. note::

:func:`create_task` (added in Python 3.7) is the preferable way
for spawning new tasks.

.. seealso::

The :func:`create_task` function and
:meth:`AbstractEventLoop.create_task` method.
The :meth:`AbstractEventLoop.create_task` method.

.. function:: wrap_future(future, \*, loop=None)

Expand Down
11 changes: 1 addition & 10 deletions Lib/asyncio/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"""Support for tasks, coroutines and the scheduler."""

__all__ = (
'Task', 'create_task',
'Task',
'FIRST_COMPLETED', 'FIRST_EXCEPTION', 'ALL_COMPLETED',
'wait', 'wait_for', 'as_completed', 'sleep',
'gather', 'shield', 'ensure_future', 'run_coroutine_threadsafe',
Expand Down Expand Up @@ -294,15 +294,6 @@ def _wakeup(self, future):
Task = _CTask = _asyncio.Task


def create_task(coro):
"""Schedule the execution of a coroutine object in a spawn task.

Return a Task object.
"""
loop = events.get_running_loop()
return loop.create_task(coro)


# wait() and as_completed() similar to those in PEP 3148.

FIRST_COMPLETED = concurrent.futures.FIRST_COMPLETED
Expand Down
13 changes: 0 additions & 13 deletions Lib/test/test_asyncio/test_tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2163,19 +2163,6 @@ def test_create_task_with_asynclike_function(self):
self.assertIsInstance(task, self.Task)
self.assertEqual(self.loop.run_until_complete(task), 42)

def test_bare_create_task(self):

async def inner():
return 1

async def coro():
task = asyncio.create_task(inner())
self.assertIsInstance(task, self.Task)
ret = await task
self.assertEqual(1, ret)

self.loop.run_until_complete(coro())


def add_subclass_tests(cls):
BaseTask = cls.Task
Expand Down
9 changes: 0 additions & 9 deletions Misc/NEWS.d/3.7.0a4.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,15 +410,6 @@ unified API for reading resources contained within packages. Also add

..

.. bpo: 32311
.. date: 2017-12-14-17-28-54
.. nonce: DL5Ytn
.. section: Library

Implement asyncio.create_task(coro) shortcut

..

.. bpo: 32327
.. date: 2017-12-14-16-00-25
.. nonce: bbkSxA
Expand Down