bpo-32232: Fix "building extensions as builtins is broken in 3.7"#5256
bpo-32232: Fix "building extensions as builtins is broken in 3.7"#5256pablogsal wants to merge 1 commit into
Conversation
c48bb00 to
eedb7ad
Compare
|
Microsoft compiler does not handle well the circular dependencies between |
4fb707d to
4ef5971
Compare
ned-deily
left a comment
There was a problem hiding this comment.
Thanks for making the test case and PR!! This is just a cursory review. I won't have time for a thorough review prior to 3.7.0b1 and someone else should review it, too, particular @doko42. Comments: The test in the PR fails as it stands; see the Travis CI output. The test_support module is there to test things in the test support module; this new test case does not belong there (though I'm not sure where, it might need a new file?). The test fails if run from an installed Python rather than from a build directory: the base_dir path calculation needs to handle both cases, see other tests for examples. (You can test an installed Python by using something like ./configure --prefix=/tmp/pybin; make ...; make install; cd /out/of/the/build/directory ; /tmp/pybin/python3 -m test ... ) Building of all of those modules will be problematic because some depend on compiling and linking with third-party libraries which may not be present or whose paths are platform dependent. So perhaps simplify the list of modules to those without external dependencies.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I am going to close this because testing building CPython is not very reliable though the test themselves. |
The patch involvin
Include/internal/pystate.handInclude/pystate.his by @doko42.https://bugs.python.org/issue32232