Skip to content

bpo-32232: Fix "building extensions as builtins is broken in 3.7"#5256

Closed
pablogsal wants to merge 1 commit into
python:masterfrom
pablogsal:bpo32232
Closed

bpo-32232: Fix "building extensions as builtins is broken in 3.7"#5256
pablogsal wants to merge 1 commit into
python:masterfrom
pablogsal:bpo32232

Conversation

@pablogsal

@pablogsal pablogsal commented Jan 21, 2018

Copy link
Copy Markdown
Member

The patch involvin Include/internal/pystate.h and Include/pystate.h is by @doko42.

https://bugs.python.org/issue32232

@pablogsal

Copy link
Copy Markdown
Member Author

Microsoft compiler does not handle well the circular dependencies between Include/pystate.h and Include/internal/pystate.h so I have included guards for Windows in the new include for Include/pystate.h and deactivated the test in that case.

@pablogsal pablogsal force-pushed the bpo32232 branch 12 times, most recently from 4fb707d to 4ef5971 Compare January 23, 2018 17:40

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the test case and PR!! This is just a cursory review. I won't have time for a thorough review prior to 3.7.0b1 and someone else should review it, too, particular @doko42. Comments: The test in the PR fails as it stands; see the Travis CI output. The test_support module is there to test things in the test support module; this new test case does not belong there (though I'm not sure where, it might need a new file?). The test fails if run from an installed Python rather than from a build directory: the base_dir path calculation needs to handle both cases, see other tests for examples. (You can test an installed Python by using something like ./configure --prefix=/tmp/pybin; make ...; make install; cd /out/of/the/build/directory ; /tmp/pybin/python3 -m test ... ) Building of all of those modules will be problematic because some depend on compiling and linking with third-party libraries which may not be present or whose paths are platform dependent. So perhaps simplify the list of modules to those without external dependencies.

@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pablogsal pablogsal changed the title bpo-32232: Fix RELEASE_BLOCKER "building extensions as builtins is broken in 3.7" bpo-32232: Fix "building extensions as builtins is broken in 3.7" Feb 10, 2018
@pablogsal

Copy link
Copy Markdown
Member Author

I am going to close this because testing building CPython is not very reliable though the test themselves.

@pablogsal pablogsal closed this Feb 19, 2018
@pablogsal pablogsal deleted the bpo32232 branch February 19, 2018 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants