Skip to content

bpo-32677: Add .isascii() to str, bytes and bytearray #5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 12 commits into from
Jan 27, 2018
Merged

bpo-32677: Add .isascii() to str, bytes and bytearray #5342

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1d4c0f4
Implement str.isascii()
methane Jan 26, 2018
4b01174
Add tests and doc
methane Jan 26, 2018
8b6452f
Add NEWS entry
methane Jan 26, 2018
120579a
fix
methane Jan 26, 2018
22a8400
s/ascii/ASCII/
methane Jan 26, 2018
56b7727
Fix UserString
methane Jan 26, 2018
3fb3240
Update doc with Victor's suggestion
methane Jan 26, 2018
949b3ad
Update doc
methane Jan 26, 2018
5289bae
Add bytes.isascii() and bytearray.isascii()
methane Jan 26, 2018
40e08a0
Add test for bytes.isascii()
methane Jan 26, 2018
4138202
Fix test_doctest
methane Jan 27, 2018
91a6b18
Update NEWS entry
methane Jan 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for bytes.isascii()
  • Loading branch information
@methane
methane committed Jan 26, 2018
commit 40e08a0b2b42ccef9d8b8331543c25718275f1dd
8 changes: 8 additions & 0 deletions Lib/test/string_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,6 +909,14 @@ def test_isalnum(self):
self.checkequal(False, 'abc\n', 'isalnum')
self.checkraises(TypeError, 'abc', 'isalnum', 42)

def test_isascii(self):
self.checkequal(True, '', 'isascii')
self.checkequal(True, '\x00', 'isascii')
self.checkequal(True, '\x7f', 'isascii')
self.checkequal(True, '\x00\x7f', 'isascii')
self.checkequal(False, '\x80', 'isascii')
self.checkequal(False, '\xe9', 'isascii')

def test_isdigit(self):
self.checkequal(False, '', 'isdigit')
self.checkequal(False, 'a', 'isdigit')
Expand Down
11 changes: 3 additions & 8 deletions Lib/test/test_unicode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,14 +639,9 @@ def test_isalpha(self):
self.assertFalse('\U0001F46F'.isalpha())

def test_isascii(self):
self.assertTrue("".isascii())
self.assertTrue("\0".isascii())
self.assertTrue("\x7f".isascii())
self.assertFalse("\x80".isascii())
self.assertTrue(" \x7f".isascii())
self.assertFalse(" \x80".isascii())
self.assertTrue("\x7f ".isascii())
self.assertFalse("\x80 ".isascii())
super().test_isascii()
self.assertFalse("\u20ac".isascii())
self.assertFalse("\U0010ffff".isascii())

def test_isdecimal(self):
self.checkequalnofix(False, '', 'isdecimal')
Expand Down