Skip to content

bpo-32756: fix(Lib: argparse): don't raise exception when encountering uknown explicit arg#5512

Closed
actionless wants to merge 1 commit into
python:masterfrom
actionless:argparse-exception-on-uknown-arg
Closed

bpo-32756: fix(Lib: argparse): don't raise exception when encountering uknown explicit arg#5512
actionless wants to merge 1 commit into
python:masterfrom
actionless:argparse-exception-on-uknown-arg

Conversation

@actionless

@actionless actionless commented Feb 3, 2018

Copy link
Copy Markdown

will add bpo reference after creating

https://bugs.python.org/issue32756

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@actionless actionless changed the title fix(Lib: argparse): don't raise exception when encountering uknown explicit arg bpo-32756: fix(Lib: argparse): don't raise exception when encountering uknown explicit arg Feb 3, 2018
@actionless actionless force-pushed the argparse-exception-on-uknown-arg branch 2 times, most recently from ba36434 to df1f02b Compare February 3, 2018 13:15
@actionless

Copy link
Copy Markdown
Author

closing according to the discussion on the bug tracker

also more practical testing of the patch shown what there are few more similar cases uncovered when parsing combined args

@actionless actionless closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants