Skip to content

Fix typo in Include/objimpl.h#5568

Merged
Mariatta merged 1 commit into
python:masterfrom
WouldYouKindly:WouldYouKindly-patch-1
Feb 6, 2018
Merged

Fix typo in Include/objimpl.h#5568
Mariatta merged 1 commit into
python:masterfrom
WouldYouKindly:WouldYouKindly-patch-1

Conversation

@WouldYouKindly

Copy link
Copy Markdown
Contributor

No description provided.

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @WouldYouKindly for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2018
)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-5569 is a backport of this pull request to the 3.7 branch.

@Mariatta

Mariatta commented Feb 6, 2018

Copy link
Copy Markdown
Member

Thanks @WouldYouKindly and congrats on your first contribution to CPython 🌮
For this one word change to the comments, the CLA is not needed. But please sign it for your future contributions.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2018
)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-5570 is a backport of this pull request to the 3.6 branch.

@bedevere-bot

Copy link
Copy Markdown

GH-5571 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 6, 2018
)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
miss-islington added a commit that referenced this pull request Feb 12, 2018
…H-5569)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
miss-islington added a commit that referenced this pull request Feb 12, 2018
…H-5570)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
miss-islington added a commit that referenced this pull request Feb 12, 2018
…H-5571)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants