Skip to content

bpo-32898: Fix debug build crash with COUNT_ALLOCS#5800

Merged
benjaminp merged 5 commits into
python:masterfrom
eduardo-elizondo:master
Feb 22, 2018
Merged

bpo-32898: Fix debug build crash with COUNT_ALLOCS#5800
benjaminp merged 5 commits into
python:masterfrom
eduardo-elizondo:master

Conversation

@eduardo-elizondo

@eduardo-elizondo eduardo-elizondo commented Feb 21, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

The following build crashed:
mkdir debug && cd debug
../configure --with-pydebug
make EXTRA_CFLAGS="-DCOUNT_ALLOCS"

The bug was introduced in: 25420fe

Fix:

  1. s/inter/interp/
  2. Declare PyTypeObject

https://bugs.python.org/issue32898

@the-knights-who-say-ni

the-knights-who-say-ni commented Feb 21, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@eduardo-elizondo eduardo-elizondo changed the title [Build] Fix debug build errors bpo-32898: Fix debug build errors Feb 21, 2018
@eduardo-elizondo eduardo-elizondo changed the title bpo-32898: Fix debug build errors bpo-32898: Fix debug build errors (no news) Feb 21, 2018
@eduardo-elizondo

eduardo-elizondo commented Feb 21, 2018

Copy link
Copy Markdown
Contributor Author

Signed CLA. It should be ready within a couple of hours?

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Feb 21, 2018
@serhiy-storchaka

serhiy-storchaka commented Feb 21, 2018

Copy link
Copy Markdown
Member

Yes, it should be ready within a couple of hours.

Please add your name in Misc/ACKS and add a news entry (you can use the blurb utility as described in the developer guide).

@eduardo-elizondo eduardo-elizondo changed the title bpo-32898: Fix debug build errors (no news) bpo-32898: Fix debug build errors Feb 21, 2018
@eduardo-elizondo eduardo-elizondo changed the title bpo-32898: Fix debug build errors bpo-32898: Fix debug build crash with COUNT_ALLOCS Feb 21, 2018
@eduardo-elizondo

eduardo-elizondo commented Feb 21, 2018

Copy link
Copy Markdown
Contributor Author

Ready!

@benjaminp benjaminp merged commit 745dc65 into python:master Feb 22, 2018
@miss-islington

miss-islington commented Feb 22, 2018

Copy link
Copy Markdown
Contributor

Thanks @eduardo-elizondo for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2018
@eduardo-elizondo @miss-islington
closes bpo-32898: Fix debug build crash with COUNT_ALLOCS (pythonGH-5800
e1ef183 
)

(cherry picked from commit 745dc65)

Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 22, 2018

Copy link
Copy Markdown

GH-5806 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Feb 22, 2018
@miss-islington @eduardo-elizondo
closes bpo-32898: Fix debug build crash with COUNT_ALLOCS (GH-5800)
bc2e110 
(cherry picked from commit 745dc65)

Co-authored-by: Eddie Elizondo <eduardo.elizondorueda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eduardo-elizondo @the-knights-who-say-ni @serhiy-storchaka @miss-islington @bedevere-bot @benjaminp