Skip to content

bpo-29741: make some BytesIO methods accept integer types (only changes in Modules/_io)#606

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
orenmn:bpo29741-narrow-make-some-BytesIO-methods-accept-integer-types
Mar 10, 2017
Merged

bpo-29741: make some BytesIO methods accept integer types (only changes in Modules/_io)#606
serhiy-storchaka merged 3 commits into
python:masterfrom
orenmn:bpo29741-narrow-make-some-BytesIO-methods-accept-integer-types

Conversation

@orenmn

@orenmn orenmn commented Mar 10, 2017

Copy link
Copy Markdown
Contributor

according to http://bugs.python.org/issue29741:

  • change some functions in Modules/_io/stringio.c and in Modules/_io/bytesio.c to use _PyIO_ConvertSsize_t (which accepts integer types)
  • change _io_BytesIO_truncate_impl so that it would accept integer types

(I ran the test module again on my Ubuntu 16.04 VM, and none of the tests failed.)

@mention-bot

Copy link
Copy Markdown

@orenmn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @avassalotti, @benjaminp, @loewis and @vadmium to be potential reviewers.

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 10, 2017
@serhiy-storchaka serhiy-storchaka merged commit 7400254 into python:master Mar 10, 2017
orenmn added a commit to orenmn/cpython that referenced this pull request Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants