Skip to content

bpo-33078 FIX failure on OSX sem_getvalue#6180

Merged
pitrou merged 1 commit into
python:masterfrom
tomMoral:PR_fix_osx_33078
Mar 21, 2018
Merged

bpo-33078 FIX failure on OSX sem_getvalue#6180
pitrou merged 1 commit into
python:masterfrom
tomMoral:PR_fix_osx_33078

Conversation

@tomMoral

@tomMoral tomMoral commented Mar 21, 2018

Copy link
Copy Markdown
Contributor

@tomMoral

tomMoral commented Mar 21, 2018

Copy link
Copy Markdown
Contributor Author

@pitrou the test relying on qsize introduced in #6119 fails on OSX because it relies on sem_getvalue which is not present. I propose this patch to avoid the failures.

@pitrou

pitrou commented Mar 21, 2018

Copy link
Copy Markdown
Member

I'm gonna merge since our macOS CI on Travis is broken.

@pitrou pitrou merged commit dec1c77 into python:master Mar 21, 2018
@bedevere-bot

Copy link
Copy Markdown

@pitrou: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @tomMoral for the PR, and @pitrou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-6181 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2018
(cherry picked from commit dec1c77)

Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
pitrou pushed a commit that referenced this pull request Mar 21, 2018
(cherry picked from commit dec1c77)

Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
jo2y pushed a commit to jo2y/cpython that referenced this pull request Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants