[3.7] bpo-33358: Fix test_embed.test_pre_initialization_sys_options (GH-6612)#6618
Merged
Merged
Conversation
Member
|
I tested manually Python 3.7 with --enabled-shared: test_embed fails without this change, and pass with this change. |
Member
|
cc @pablogsal |
Contributor
Author
|
@pablogsal and @vstinner: Backport status check is done, and it's a success ✅ . |
Contributor
Author
|
Thanks! |
Member
Oh wow, that was fast. Now I really saw that bot doing an actual merge. Impressive work @Mariatta! |
Member
|
Thanks again, good bot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test_embed.test_pre_initialization_sys_options() when building with --enable-shared
(cherry picked from commit 4114846)
Co-authored-by: Pablo Galindo Pablogsal@gmail.com
https://bugs.python.org/issue33358