bpo-5755: remove compiler flag -Wstrict-prototypes#6791
Closed
jdemeyer wants to merge 1 commit into
Closed
Conversation
jdemeyer
changed the title
Contributor
Author
|
CC @grimreaper |
Contributor
|
Strict Prototypes is correct and helpful for C. That said, the way it is currently implemented, by checking for the compiler in CC is sub-optimal at best. Please also remove TL;DR; +1 to this change; distutils should be fixed to not use python's CFLAGS; we should re-add strict-prototypes to CFLAGS when distutils is fixed. |
methane
approved these changes
Jun 4, 2018
Member
|
PR-7395 was merged, and backported to 3.7 and 3.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue5755