Skip to content

bpo-33505: Optimize asyncio.ensure_future by reordering if conditions #6832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimmylai wants to merge 13 commits into from
Closed

bpo-33505: Optimize asyncio.ensure_future by reordering if conditions #6832

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e5ec056
call remove_done_callback in finally section
May 21, 2017
9f7ad5a
Merge pull request #1 from jimmylai/jimmylai-patch-asyncio-orphan-fut…
May 21, 2017
923312f
Merge branch 'master' of https://github.com/python/cpython
Sep 4, 2017
d0ccfac
[asyncio] bpo-30423 bug: add regression test for orphan future causes…
Sep 4, 2017
4bd4b45
Update test_base_events.py
asvetlov Nov 1, 2017
58deb49
Update test_base_events.py
asvetlov Nov 1, 2017
d914928
Merge branch 'master' of https://github.com/python/cpython
jimmylai Nov 17, 2017
167daa1
Merge branch 'master' of https://github.com/python/cpython
May 14, 2018
28bb6fd
Merge branch 'master' of https://github.com/python/cpython
May 14, 2018
602d100
bpo-33505: Optimize asyncio.ensure_future by reordering if conditions
May 14, 2018
c9e1bff
bpo-33494: Change dataclasses.Fields repr to use the repr of each of …
May 14, 2018
b10725b
bpo-33505: Optimize asyncio.ensure_future by reordering if conditions
May 14, 2018
d4d41ef
Merge branch 'master' of https://github.com/jimmylai/cpython
May 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Lib/asyncio/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,17 +542,17 @@ def ensure_future(coro_or_future, *, loop=None):

If the argument is a Future, it is returned directly.
"""
if futures.isfuture(coro_or_future):
if loop is not None and loop is not futures._get_loop(coro_or_future):
raise ValueError('loop argument must agree with Future')
return coro_or_future
elif coroutines.iscoroutine(coro_or_future):
if coroutines.iscoroutine(coro_or_future):
if loop is None:
loop = events.get_event_loop()
task = loop.create_task(coro_or_future)
if task._source_traceback:
del task._source_traceback[-1]
return task
elif futures.isfuture(coro_or_future):
if loop is not None and loop is not futures._get_loop(coro_or_future):
raise ValueError('loop argument must agree with Future')
return coro_or_future
elif inspect.isawaitable(coro_or_future):
return ensure_future(_wrap_awaitable(coro_or_future), loop=loop)
else:
Expand Down