bpo-12486: Document tokenize.generate_tokens() as public API#6957
Merged
Conversation
Carreau
approved these changes
May 17, 2018
Carreau
left a comment
Carreau
left a comment
Contributor
There was a problem hiding this comment.
It's also widely used:
https://github.com/search?l=Python&q=generate_tokens&type=Code
Contributor
Author
|
The test failures appear to be unrelated to this pull request (there's a |
Contributor
Author
|
Close/reopen, hopefully that will rerun tests. |
willingc
approved these changes
Jun 5, 2018
willingc
left a comment
willingc
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks @takluyver
|
@willingc: Please replace |
Contributor
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think discussions of tokenizing unicode have often got caught up in trying to design nicer APIs for it. I am taking the much lazier approach of promoting the existing but undocumented
generate_tokensAPI to a public API.Why should we do this?
generate_tokens()has been there for several releases already (at least since 3.3.0), so we can start using it without having to wait until a new Python version is widespread.tokenize(), so it's easy to understand.https://bugs.python.org/issue12486