Skip to content

bpo-2504: Add pgettext() and variants to gettext#7253

Merged
serhiy-storchaka merged 7 commits into
python:masterfrom
csabella:bpo2504
Nov 7, 2018
Merged

bpo-2504: Add pgettext() and variants to gettext#7253
serhiy-storchaka merged 7 commits into
python:masterfrom
csabella:bpo2504

Conversation

@csabella

@csabella csabella commented May 30, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Original patch by Franz Glasner.

https://bugs.python.org/issue2504

serhiy-storchaka
serhiy-storchaka reviewed May 31, 2018
View reviewed changes
Comment thread Doc/library/gettext.rst Outdated
@damufo

damufo commented Oct 26, 2018

Copy link
Copy Markdown

Hello:
How is this?
I think it would be interesting to complete it.
Being able to use context in gettext would allow for example to specify the gender.

serhiy-storchaka
serhiy-storchaka requested changes Oct 27, 2018
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove l*gettext() functions and fix the documentation.

@bedevere-bot

bedevere-bot commented Oct 27, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella

csabella commented Oct 28, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

@bedevere-bot

bedevere-bot commented Oct 28, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

serhiy-storchaka
serhiy-storchaka reviewed Oct 29, 2018
View reviewed changes
Comment thread Doc/library/gettext.rst Outdated
Comment thread Doc/library/gettext.rst Outdated
Comment thread Lib/gettext.py Outdated
Comment thread Tools/i18n/msgfmt.py Outdated
Comment thread Tools/i18n/msgfmt.py Outdated
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Oct 29, 2018
@serhiy-storchaka

serhiy-storchaka commented Oct 29, 2018

Copy link
Copy Markdown
Member

Please add also a What's New entry.

serhiy-storchaka
serhiy-storchaka reviewed Nov 2, 2018
View reviewed changes
Comment thread Doc/library/gettext.rst Outdated
serhiy-storchaka
serhiy-storchaka reviewed Nov 2, 2018
View reviewed changes
Comment thread Doc/whatsnew/3.8.rst Outdated
@serhiy-storchaka serhiy-storchaka merged commit 637a33b into python:master Nov 7, 2018
@csabella csabella deleted the bpo2504 branch November 15, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csabella @damufo @bedevere-bot @serhiy-storchaka @merwok @the-knights-who-say-ni