Skip to content

bpo-33764: Appveyor fixes#7364

Merged
ned-deily merged 3 commits into
python:masterfrom
zware:appveyor_fixes
Jun 4, 2018
Merged

bpo-33764: Appveyor fixes#7364
ned-deily merged 3 commits into
python:masterfrom
zware:appveyor_fixes

Conversation

@zware

@zware zware commented Jun 3, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@zware zware self-assigned this Jun 3, 2018
@zware

zware commented Jun 3, 2018

Copy link
Copy Markdown
Member Author

It appears that AppVeyor is not accepting builds from us at the moment; I'm not sure why. I've tested this on my own clone (zware#8), though, and from a sample size of one it appears to both speed up the build and prevent the crash.

@terryjreedy if this comes unblocked and I haven't already done it, please feel free to merge.

@ned-deily ned-deily mentioned this pull request Jun 4, 2018
Closed
@vstinner vstinner changed the title Appveyor fixes bpo-33764: Appveyor fixes Jun 4, 2018
@vstinner

vstinner commented Jun 4, 2018

Copy link
Copy Markdown
Member

I closed my PR #7368 as a duplicate of this one.

@vstinner

vstinner commented Jun 4, 2018

Copy link
Copy Markdown
Member

And now we cannot merge this PR because of https://bugs.python.org/issue33765 ? AppVeyor, you are not funny with us :-( Is a Python release manager allowed to merge such change? @ned-deily?

@ned-deily ned-deily merged commit 47a6c79 into python:master Jun 4, 2018
@miss-islington

miss-islington commented Jun 4, 2018

Copy link
Copy Markdown
Contributor

Thanks @zware for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jun 4, 2018

Copy link
Copy Markdown

GH-7369 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2018
@zware @miss-islington
bpo-33764: Appveyor fixes (pythonGH-7364)
04bb87e 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
(cherry picked from commit 47a6c79)

Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
@miss-islington

miss-islington commented Jun 4, 2018

Copy link
Copy Markdown
Contributor

Sorry, @zware and @ned-deily, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 47a6c79f0986ce9a84d0efc3c565b28255042911 2.7

@miss-islington miss-islington assigned ned-deily and unassigned zware Jun 4, 2018
@vstinner

vstinner commented Jun 4, 2018

Copy link
Copy Markdown
Member

It would be nice to see a new AppVeyor build with this new configuration, before merging backports.

@miss-islington

miss-islington commented Jun 4, 2018

Copy link
Copy Markdown
Contributor

Sorry, @zware and @ned-deily, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 47a6c79f0986ce9a84d0efc3c565b28255042911 3.6

ned-deily pushed a commit that referenced this pull request Jun 4, 2018
@miss-islington @zware @ned-deily
bpo-33764: Appveyor fixes (GH-7364) (GH-7369)
37343a2 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
(cherry picked from commit 47a6c79)

Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Jun 4, 2018
@zware @ned-deily
bpo-33764: Appveyor fixes (pythonGH-7364)
0839542 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
@bedevere-bot

bedevere-bot commented Jun 4, 2018

Copy link
Copy Markdown

GH-7379 is a backport of this pull request to the 3.6 branch.

ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Jun 4, 2018
@zware @ned-deily
bpo-33764: Appveyor fixes (pythonGH-7364)
a23f404 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
@bedevere-bot

bedevere-bot commented Jun 4, 2018

Copy link
Copy Markdown

GH-7380 is a backport of this pull request to the 2.7 branch.

ned-deily added a commit that referenced this pull request Jun 4, 2018
@ned-deily
bpo-33764: Appveyor fixes (GH-7364) (GH-7379)
b8f2fb5 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
ned-deily added a commit that referenced this pull request Jun 4, 2018
@ned-deily
bpo-33764: Appveyor fixes (GH-7364) (GH-7380)
1cbdbf3 
* Prevent spurious message if taking a shortcut
* Fix YAML style
* Disable largefile tests
@zware zware deleted the appveyor_fixes branch June 22, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ned-deily ned-deily

Labels

OS-windows skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zware @vstinner @miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni