bpo-29734: nt._getfinalpathname handle leak#740
Merged
Conversation
|
@thebecwar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @serhiy-storchaka and @giampaolo to be potential reviewers. |
eryksun
reviewed
Jan 12, 2019
- Make sure that failure paths call CloseHandle - Fix inconsistent flags in GetFinalPathNameByHandleW calls - Move CloseHandle call from get_target_path to its calling function. - Add unit test to check that the fix works, and prevent regression
thebecwar
force-pushed
the
29734-Fix_Handle_Leaks
branch
from
67e7dd6 to
23bfba7
Compare
Contributor
|
Thanks @thebecwar for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 2, 2019
Make sure that failure paths call CloseHandle outside of the function that failed (cherry picked from commit b82bfac) Co-authored-by: Mark Becwar <mark@thebecwar.com>
|
GH-11740 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue29734
https://bugs.python.org/issue29734