Skip to content

[2.7] bpo-5755: don't use compiler flag -Wstrict-prototypes (GH-7395) #7476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jdemeyer wants to merge 1 commit into from
Closed

[2.7] bpo-5755: don't use compiler flag -Wstrict-prototypes (GH-7395) #7476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Build/2018-05-14-11-57-56.bpo-5755.kpNUx-.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
No longer use the ``-Wstrict-prototypes`` compiler flag.
This avoids a compiler warning when compiling C++ extension modules
with distutils.
9 changes: 3 additions & 6 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6011,9 +6011,6 @@ if test "${OPT-unset}" = "unset"
then
case $GCC in
yes)
if test "$CC" != 'g++' ; then
STRICT_PROTO="-Wstrict-prototypes"
fi
# For gcc 4.x we need to use -fwrapv so lets check if its supported
if "$CC" -v --help 2>/dev/null |grep -- -fwrapv > /dev/null; then
WRAP="-fwrapv"
Expand All @@ -6030,13 +6027,13 @@ then
if test "$Py_DEBUG" = 'true' ; then
# Optimization messes up debuggers, so turn it off for
# debug builds.
OPT="-g -O0 -Wall $STRICT_PROTO"
OPT="-g -O0 -Wall"
else
OPT="-g $WRAP -O3 -Wall $STRICT_PROTO"
OPT="-g $WRAP -O3 -Wall"
fi
;;
*)
OPT="-O3 -Wall $STRICT_PROTO"
OPT="-O3 -Wall"
;;
esac
case $ac_sys_system in
Expand Down
9 changes: 3 additions & 6 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1071,9 +1071,6 @@ if test "${OPT-unset}" = "unset"
then
case $GCC in
yes)
if test "$CC" != 'g++' ; then
STRICT_PROTO="-Wstrict-prototypes"
fi
# For gcc 4.x we need to use -fwrapv so lets check if its supported
if "$CC" -v --help 2>/dev/null |grep -- -fwrapv > /dev/null; then
WRAP="-fwrapv"
Expand All @@ -1090,13 +1087,13 @@ then
if test "$Py_DEBUG" = 'true' ; then
# Optimization messes up debuggers, so turn it off for
# debug builds.
OPT="-g -O0 -Wall $STRICT_PROTO"
OPT="-g -O0 -Wall"
else
OPT="-g $WRAP -O3 -Wall $STRICT_PROTO"
OPT="-g $WRAP -O3 -Wall"
fi
;;
*)
OPT="-O3 -Wall $STRICT_PROTO"
OPT="-O3 -Wall"
;;
esac
case $ac_sys_system in
Expand Down