Skip to content

bpo-33818: PyExceptionClass_Name() will now return "const char *".#7581

Merged
serhiy-storchaka merged 4 commits into
python:masterfrom
serhiy-storchaka:PyExceptionClass_Name-const-char
Jun 15, 2018
Merged

bpo-33818: PyExceptionClass_Name() will now return "const char *".#7581
serhiy-storchaka merged 4 commits into
python:masterfrom
serhiy-storchaka:PyExceptionClass_Name-const-char

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 10, 2018

Copy link
Copy Markdown
Member

This PR is purposed for backporting in 3.7. If this change will not be applied to 3.7, What's New will need to be changed.

https://bugs.python.org/issue33818

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted on the bug issue, I do not see a compelling reason to introduce this interface change at this very late stage of the 3.7.0 release. Let's target it for 3.8.

Also, note that the "make suspicious" check failed.

@bedevere-bot

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@ned-deily

Copy link
Copy Markdown
Member

I should note that I believe this arose because of the changes for bpo-33738 (#7585) which are trying to make the stable ABI usable again. As I understand it, the change there should have minimal user impact as the stable ABI is obviously not being used with current versions of 3.x.

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

Re-targeted for 3.8. I have made the requested changes; please review again.

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

@serhiy-storchaka serhiy-storchaka merged commit ceeef10 into python:master Jun 15, 2018
@serhiy-storchaka serhiy-storchaka deleted the PyExceptionClass_Name-const-char branch June 15, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants