Skip to content

bpo-33913: Fix test_multiprocessing_main_handling#7972

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:mp_main_handling
Jun 27, 2018
Merged

bpo-33913: Fix test_multiprocessing_main_handling#7972
vstinner merged 1 commit into
python:masterfrom
vstinner:mp_main_handling

Conversation

@vstinner

@vstinner vstinner commented Jun 27, 2018

Copy link
Copy Markdown
Member

bpo-30339, bpo-33913:

  • Increase timeout from 10 seconds to 1 minute in
    test_source_main_skipped_in_children source of
    test_multiprocessing_main_handling.
  • Replace time.time() with time.monotonic().
  • On timeout, include the duration in the error message.

https://bugs.python.org/issue33913

bpo-30339, bpo-33913:

* Increase timeout from 10 seconds to 1 minute in
  test_source_main_skipped_in_children source of
  test_multiprocessing_main_handling.
* Replace time.time() with time.monotonic().
* On timeout, include the duration in the error message.
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@vstinner vstinner deleted the mp_main_handling branch June 27, 2018 20:21
@bedevere-bot

Copy link
Copy Markdown

GH-7973 is a backport of this pull request to the 3.7 branch.

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 64737e9ae2081e529935ecf07f44e89f362d1c4b 3.6

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2018
bpo-30339, bpo-33913:

* Increase timeout from 10 seconds to 1 minute in
  test_source_main_skipped_in_children source of
  test_multiprocessing_main_handling.
* Replace time.time() with time.monotonic().
* On timeout, include the duration in the error message.
(cherry picked from commit 64737e9)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot

Copy link
Copy Markdown

GH-7976 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Jun 27, 2018
bpo-30339, bpo-33913:

* Increase timeout from 10 seconds to 1 minute in
  test_source_main_skipped_in_children source of
  test_multiprocessing_main_handling.
* Replace time.time() with time.monotonic().
* On timeout, include the duration in the error message.
(cherry picked from commit 64737e9)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
vstinner added a commit that referenced this pull request Jun 27, 2018
bpo-30339, bpo-33913:

* Increase timeout from 10 seconds to 1 minute in
  test_source_main_skipped_in_children source of
  test_multiprocessing_main_handling.
* Replace time.time() with time.monotonic().
* On timeout, include the duration in the error message.

(cherry picked from commit 64737e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants