[2.7] bpo-34019: Fix wrong arguments for Opera Browser (GH-8047)#8126
Merged
Conversation
The Opera Browser was using a outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module. * Correct the arguments passed to the Opera Browser when opening a new URL.. (cherry picked from commit 3cf1f15) Co-authored-by: Bumsik Kim <k.bumsik@gmail.com>
vstinner
approved these changes
Jul 6, 2018
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM.
I tried to backport test_webbrowser, but it requires a lot of changes.
|
@pablogsal: Please replace |
Member
Author
|
@bedevere-bot The backport made me put my guard down 😮 I won't fail again :) |
holatuwol
added a commit
to holatuwol/liferay-faster-deploy
that referenced
this pull request
Nov 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Opera Browser was using an outdated command line invocation that resulted in an incorrect URL being opened in the browser when requested using the webbrowser module.
(cherry picked from commit 3cf1f15)
Co-authored-by: Bumsik Kim k.bumsik@gmail.com
https://bugs.python.org/issue34019