Skip to content

bpo-34261: Add description to clinic.py#8518

Merged
pablogsal merged 1 commit into
python:masterfrom
timhoffm:clinic-description
Jun 2, 2019
Merged

bpo-34261: Add description to clinic.py#8518
pablogsal merged 1 commit into
python:masterfrom
timhoffm:clinic-description

Conversation

@timhoffm

@timhoffm timhoffm commented Jul 28, 2018

Copy link
Copy Markdown
Contributor

Add description to clinic.py

This PR adds a short description to clinic.py to help contributors understand what it's used for (This was something I was stumbling upon personally when trying to update a docstring of a CPython builtin).

https://bugs.python.org/issue34261

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@timhoffm

Copy link
Copy Markdown
Contributor Author

Note: I've now signed the CLA.

@pablogsal

Copy link
Copy Markdown
Member

Hi @timhoffm and thank you for your contribution!

Could you open an issue in the tracker and link it against this Pull Request as described in the devguide: https://devguide.python.org//pullrequest/? This will help us track the issue and discuss different aspects of it there.

@pablogsal

Copy link
Copy Markdown
Member

Also, you need to fix the trailing whitespace in clinic.py:

You can use Tools/scripts/patchcheck.py for that if you want.

@timhoffm timhoffm force-pushed the clinic-description branch from d7b1cd3 to ecb58fb Compare July 28, 2018 12:34
@timhoffm timhoffm changed the title Add description to clinic.py bpo-34261: Add description to clinic.py Jul 28, 2018
@timhoffm

timhoffm commented Jun 1, 2019

Copy link
Copy Markdown
Contributor Author

@pablogsal I think the issues are addressed. ISs there anything else I have to do?

@pablogsal

Copy link
Copy Markdown
Member

Thanks, @timhoffm for your contribution! 🎉

@timhoffm timhoffm deleted the clinic-description branch June 2, 2019 17:05
@python python deleted a comment from bedevere-bot Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants