Skip to content

bpo-34035: Fix several AttributeError in zipfile seek() methods#8527

Merged
serhiy-storchaka merged 4 commits into
python:masterfrom
BoboTiG:fix-issue-34035
Jul 29, 2018
Merged

bpo-34035: Fix several AttributeError in zipfile seek() methods#8527
serhiy-storchaka merged 4 commits into
python:masterfrom
BoboTiG:fix-issue-34035

Conversation

@BoboTiG

@BoboTiG BoboTiG commented Jul 28, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

The ZipExtFile.seek() was not tested and several errors were not spotted. I added a test to prevent any future regression.

To be checked with @vstinner.

https://bugs.python.org/issue34035

@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 28, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

encukou
encukou reviewed Jul 28, 2018
View reviewed changes
Comment thread Lib/test/test_zipfile.py Outdated
serhiy-storchaka
serhiy-storchaka reviewed Jul 28, 2018
View reviewed changes
Comment thread Lib/test/test_zipfile.py Outdated
@BoboTiG BoboTiG force-pushed the fix-issue-34035 branch 2 times, most recently from d86ca74 to c089457 Compare July 28, 2018 15:56
@BoboTiG

BoboTiG commented Jul 29, 2018

Copy link
Copy Markdown
Contributor Author

CLA signed :)

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 and removed CLA not signed labels Jul 29, 2018
@serhiy-storchaka serhiy-storchaka merged commit 3f8c691 into python:master Jul 29, 2018
@miss-islington

miss-islington commented Jul 29, 2018

Copy link
Copy Markdown
Contributor

Thanks @BoboTiG for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Jul 29, 2018

Copy link
Copy Markdown
Contributor

Sorry @BoboTiG and @serhiy-storchaka, I had trouble checking out the 3.6 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3f8c6913b82ed9c05e57175bcbfeacde46c598e3 3.6

@bedevere-bot

bedevere-bot commented Jul 29, 2018

Copy link
Copy Markdown

GH-8556 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2018
@BoboTiG @miss-islington
bpo-34035: Fix several AttributeError in zipfile seek() methods. (pyt…
26823af 
…honGH-8527)

(cherry picked from commit 3f8c691)

Co-authored-by: Mickaël Schoentgen <contact@tiger-222.fr>
miss-islington added a commit that referenced this pull request Jul 29, 2018
@miss-islington @BoboTiG
bpo-34035: Fix several AttributeError in zipfile seek() methods. (GH-…
ad4f64d 
…8527)

(cherry picked from commit 3f8c691)

Co-authored-by: Mickaël Schoentgen <contact@tiger-222.fr>
@BoboTiG BoboTiG deleted the fix-issue-34035 branch July 29, 2018 21:41
@vstinner

vstinner commented Jul 31, 2018

Copy link
Copy Markdown
Member

@BoboTiG: Oh nice, someone else reviewed and even merged your PR. Congrats!

@BoboTiG

BoboTiG commented Jul 31, 2018

Copy link
Copy Markdown
Contributor Author

@vstinner: Thank you :)
The whole experience, for a first start, was really good. So thank you all :)

@serhiy-storchaka serhiy-storchaka removed their assignment Sep 22, 2018
@yunzheng yunzheng mentioned this pull request Dec 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BoboTiG @the-knights-who-say-ni @miss-islington @bedevere-bot @vstinner @encukou @serhiy-storchaka