Skip to content

bpo-31047: Fix ntpath.abspath for invalid paths#8544

Merged
zooba merged 5 commits into
python:masterfrom
mansenfranzen:abspath_fix_win_31047
Jul 29, 2018
Merged

bpo-31047: Fix ntpath.abspath for invalid paths#8544
zooba merged 5 commits into
python:masterfrom
mansenfranzen:abspath_fix_win_31047

Conversation

@mansenfranzen

@mansenfranzen mansenfranzen commented Jul 29, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Fixes nt.abspath for invalid paths to ensure os.path.isabs(os.path.abspath(" ")) == True to behave the same as for "" or "?".

Refers to https://bugs.python.org/issue31047

Co-authored-by:

https://bugs.python.org/issue31047

@the-knights-who-say-ni

the-knights-who-say-ni commented Jul 29, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

You can check yourself
to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

zooba
zooba approved these changes Jul 29, 2018
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need the NEWS entry - click on the "Details" link for the failed check for info on how to add it. (Your PR title is a good description to put in there.)

@mansenfranzen

mansenfranzen commented Jul 29, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for the advice - added the news entry accordingly.

@zooba zooba merged commit d2e902e into python:master Jul 29, 2018
@miss-islington

miss-islington commented Jul 29, 2018

Copy link
Copy Markdown
Contributor

Thanks @mansenfranzen for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Jul 29, 2018

Copy link
Copy Markdown

GH-8549 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2018
@mansenfranzen @miss-islington
bpo-31047: Fix ntpath.abspath for invalid paths (pythonGH-8544)
f7bcf56 
(cherry picked from commit d2e902e)

Co-authored-by: Franz Wöllert <franz.woellert@gmail.com>
@miss-islington

miss-islington commented Jul 29, 2018

Copy link
Copy Markdown
Contributor

Sorry, @mansenfranzen and @zooba, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d2e902e4fb304f27e4a72356efbc1fc26be3935d 3.6

zooba pushed a commit to zooba/cpython that referenced this pull request Jul 29, 2018
@mansenfranzen @zooba
bpo-31047: Fix ntpath.abspath for invalid paths (pythonGH-8544)
4c0c3d8
@bedevere-bot

bedevere-bot commented Jul 29, 2018

Copy link
Copy Markdown

GH-8550 is a backport of this pull request to the 3.6 branch.

@zooba

zooba commented Jul 29, 2018

Copy link
Copy Markdown
Member

@mansenfranzen I'm assuming you are/were here at the EuroPython sprints and submitted the CLA form already, yes?

In any case, the code in the change matches what was provided on the issue tracker by someone who definitely has submitted it, which is why I merged already.

@mansenfranzen

mansenfranzen commented Jul 29, 2018

Copy link
Copy Markdown
Contributor Author

Yes, filled in the CLA form already.

@zooba zooba added the sprint label Jul 29, 2018
miss-islington added a commit that referenced this pull request Jul 29, 2018
@miss-islington @mansenfranzen
bpo-31047: Fix ntpath.abspath for invalid paths (GH-8544)
5753b13 
(cherry picked from commit d2e902e)

Co-authored-by: Franz Wöllert <franz.woellert@gmail.com>
@mansenfranzen

mansenfranzen commented Jul 30, 2018

Copy link
Copy Markdown
Contributor Author

CLA is signed now

zooba added a commit that referenced this pull request Aug 7, 2018
@zooba
bpo-31047: Fix ntpath.abspath for invalid paths (GH-8544)
b0bf51b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Assignees

@zooba zooba

Labels

OS-windows sprint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mansenfranzen @the-knights-who-say-ni @miss-islington @bedevere-bot @zooba @Mariatta