bpo-14465: Provide simple prett printing for XML and ETree API#8933
Closed
mcepl wants to merge 1 commit into
Closed
bpo-14465: Provide simple prett printing for XML and ETree API#8933mcepl wants to merge 1 commit into
mcepl wants to merge 1 commit into
Conversation
Comparing to the solution suggested in #4016, this should bear no performance penalty when pretty_print=False (which is the default). On the other hand, it is not suitable for processing of large XML data. Then some alternative solution (e.g., lxml module) must be used.
Contributor
Author
|
@scoder, what do you think? |
scoder
reviewed
Aug 25, 2018
| enc_lower = encoding.lower() | ||
|
|
||
| if pretty_print: | ||
| self._indent(self._root) |
Contributor
There was a problem hiding this comment.
Sorry, but write() is an output method. It shouldn't have side-effects that change the tree.
Just imagine you'd print or log the tree for debugging purposes and it would alter the serialised result later on.
Contributor
|
Rejecting this PR in its current form, because it adds a side-effect to an otherwise pure output function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparing to the solution suggested in #4016, this should bear no performance penalty when pretty_print=False (which is the default). On the other hand, it is not suitable for processing of large XML data. Then some alternative solution (e.g., lxml module) must be used.
https://bugs.python.org/issue14465