bpo-34613: document the correct value of limit argument of asyncio.StreamReader#9121
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. We also demand... A SHRUBBERY! You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
CuriousLearner
left a comment
CuriousLearner
left a comment
There was a problem hiding this comment.
Just a minor nit-pick. Rest looks good to me.
This PR does not need NEWS entry. A core-dev would be able to add skip-news label on this PR which would take care of the CI tests.
There was a problem hiding this comment.
You can mention it like this so that it is more clear:
The *limit* argument's default value is set to _DEFAULT_LIMIT which is 2**16 (64 KiB).
|
@Psycojoker You would also have to sign the CLA first from here: https://www.python.org/psf/contrib/contrib-form/ |
Psycojoker
force-pushed
the
fix-issue-34613
branch
from
df41d31 to
a9941fd
Compare
I actually did that just after making the PR and received a confirmation email but for some reason it still show me has not having signed it? My github's username match, I'm not sure if I did any mistake? |
|
@Psycojoker Check on bugs.python.org if your Contributor agreement has been received. If not, then allow at least 1 business day to get it through. |
|
@CuriousLearner bugs.python.org seems happy and https://check-python-cla.herokuapp.com/ to but the bot seems to be having trouble with setting to correct labels
|
|
This is problem with our cla-checker that appears to be case-senstive. In bpo, the GitHub username is |
|
Thanks @Psycojoker for the PR, and @miss-islington for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
…reamReader (pythonGH-9121) The default value of asyncio.StreamReader *limit* is `_DEFAULT_LIMIT` instead of `None`. <!-- issue-number: [bpo-34613](https://www.bugs.python.org/issue34613) --> https://bugs.python.org/issue34613 <!-- /issue-number --> (cherry picked from commit b4ec362) Co-authored-by: Bram <cortex@worlddomination.be>
|
GH-9175 is a backport of this pull request to the 3.7 branch. |
|
GH-9176 is a backport of this pull request to the 3.6 branch. |
…reamReader (pythonGH-9121) The default value of asyncio.StreamReader *limit* is `_DEFAULT_LIMIT` instead of `None`. <!-- issue-number: [bpo-34613](https://www.bugs.python.org/issue34613) --> https://bugs.python.org/issue34613 <!-- /issue-number --> (cherry picked from commit b4ec362) Co-authored-by: Bram <cortex@worlddomination.be>
|
Thanks @Psycojoker and congrats on your first contribution to CPython 🌮 |
…reamReader (GH-9121) The default value of asyncio.StreamReader *limit* is `_DEFAULT_LIMIT` instead of `None`. <!-- issue-number: [bpo-34613](https://www.bugs.python.org/issue34613) --> https://bugs.python.org/issue34613 <!-- /issue-number --> (cherry picked from commit b4ec362) Co-authored-by: Bram <cortex@worlddomination.be>
…reamReader (GH-9121) The default value of asyncio.StreamReader *limit* is `_DEFAULT_LIMIT` instead of `None`. <!-- issue-number: [bpo-34613](https://www.bugs.python.org/issue34613) --> https://bugs.python.org/issue34613 <!-- /issue-number --> (cherry picked from commit b4ec362) Co-authored-by: Bram <cortex@worlddomination.be>
|
Wiii thx \^-^/ :heart: |
6 participants
The default value of asyncio.StreamReader limit is
_DEFAULT_LIMITinstead ofNone.https://bugs.python.org/issue34613