bpo-34630: Skip logging SSL certificate errors by asyncio code#9169
Merged
asvetlov merged 2 commits intoSep 12, 2018
Conversation
1st1
approved these changes
Sep 12, 2018
1st1
left a comment
1st1
left a comment
Member
There was a problem hiding this comment.
Could you please make a PR to uvloop?
Contributor
Author
|
@1st1 I can point to all three places in the source code that should be updated but need your help for the actual change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't log connection errors, ssl cert error is not exceptional.
Now asyncio logs a bloated by cert error reports if asyncio is used, for example, for web crawling.
There is no way to suppress such logs, and there is no reason to log them at all.
https://bugs.python.org/issue34630