bpo-31132: Remove prlimit permission test.#9280
Merged
Merged
Conversation
This test is doesn't work when the test process is privledged, which is hard to detect.
benjaminp
changed the title
encukou
changed the title
Contributor
|
@benjaminp: Status check is done, and it's a failure ❌ . |
encukou
approved these changes
Sep 13, 2018
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
I agree that this test doesn't add much value, and actually detecting that we don't have rights.
The code was written by Christian; he says he doesn't care much.
vstinner
approved these changes
Sep 13, 2018
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. Python doesn't have to test the operating system.
Contributor
|
@benjaminp: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2018
This test is doesn't work when the test process is privledged, which is hard to detect. https://bugs.python.org/issue34668 (cherry picked from commit 01e0afa) Co-authored-by: Benjamin Peterson <benjamin@python.org>
|
GH-9283 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2018
This test is doesn't work when the test process is privledged, which is hard to detect. https://bugs.python.org/issue34668 (cherry picked from commit 01e0afa) Co-authored-by: Benjamin Peterson <benjamin@python.org>
|
GH-9284 is a backport of this pull request to the 3.6 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2018
This test is doesn't work when the test process is privledged, which is hard to detect. https://bugs.python.org/issue34668 (cherry picked from commit 01e0afa) Co-authored-by: Benjamin Peterson <benjamin@python.org>
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2018
This test is doesn't work when the test process is privledged, which is hard to detect. https://bugs.python.org/issue34668 (cherry picked from commit 01e0afa) Co-authored-by: Benjamin Peterson <benjamin@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is doesn't work when the test process is privledged, which is hard to detect.
https://bugs.python.org/issue34668