bpo-34749: Improved performance of binascii.a2b_base64().#9444
Merged
Conversation
sir-sigurd
force-pushed
the
a2b_base64
branch
2 times, most recently
from
b2f9c45 to
7593233
Compare
Contributor
Member
|
The conflicts look minor (though Git rightly thinks they're better left to humans). I don't know about all upcoming PEPs, but I'm not aware of conflicts. |
Contributor
|
@encukou, thank you for the response. This one may need to wait a little longer until a reviewer is available then. |
encukou
approved these changes
Jul 14, 2019
encukou
left a comment
encukou
left a comment
Member
There was a problem hiding this comment.
I've rebased on top of the module state changes in master.
I can still see the speedup, can't find any new bugs, and I haven't been able to speed it up more :)
Contributor
|
@sir-sigurd: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@encukou, thanks for rebasing it! |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34749