Skip to content

gh-78955: Use user-selected color theme for Help => IDLE Doc#9502

Merged
terryjreedy merged 11 commits into
python:mainfrom
terryjreedy:help_colors
May 6, 2024
Merged

gh-78955: Use user-selected color theme for Help => IDLE Doc#9502
terryjreedy merged 11 commits into
python:mainfrom
terryjreedy:help_colors

Conversation

@terryjreedy

@terryjreedy terryjreedy commented Sep 23, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@terryjreedy terryjreedy added type-feature A feature request or enhancement needs backport to 3.6 labels Sep 23, 2018
@terryjreedy terryjreedy self-assigned this Sep 23, 2018
@terryjreedy terryjreedy mentioned this pull request Sep 23, 2018
Open
@ambv

ambv commented May 17, 2022

Copy link
Copy Markdown
Contributor

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@iritkatriel

iritkatriel commented Nov 6, 2022

Copy link
Copy Markdown
Member

Updating the branch to kick off a new test run.

@terryjreedy This has been in "awaiting merge" for a few years now. What's the status?

@terryjreedy terryjreedy changed the title bpo-34774: Use user-selected color theme for Help => IDLE Help. gh-78955: Use user-selected color theme for Help => IDLE Help. Nov 6, 2022
@terryjreedy terryjreedy changed the title gh-78955: Use user-selected color theme for Help => IDLE Help. gh-78955: IDLE Help - use theme colers for viewer Nov 6, 2022
@merwok merwok changed the title gh-78955: IDLE Help - use theme colers for viewer gh-78955: IDLE Help - use theme colors for viewer Nov 22, 2022
@terryjreedy terryjreedy changed the title gh-78955: IDLE Help - use theme colors for viewer gh-78955: Use user-selected color theme for Help => IDLE Help. Nov 27, 2022
@terryjreedy terryjreedy added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Dec 23, 2022
@hugovk hugovk removed the needs backport to 3.10 only security fixes label Apr 6, 2023
@terryjreedy terryjreedy mentioned this pull request Dec 16, 2023
Closed
@nineteendo

nineteendo commented Apr 21, 2024

Copy link
Copy Markdown
Contributor

@terryjreedy, this pull request is awaiting a merge for 5.5 years. Any updates?

@hugovk hugovk added needs backport to 3.12 only security fixes and removed needs backport to 3.11 only security fixes labels Apr 22, 2024
@terryjreedy

terryjreedy commented Apr 23, 2024

Copy link
Copy Markdown
Member Author

In #78955 (comment) I noted the border color for the 2 <pre> (code) blocks on the page is seems to be fixed as black, which does not look good. The current docs have visible borders in both light and dark mode. I did not find anything else looking at tkinter and tk docs today. If I do not find otherwise in a bit more research, I will take it as is.

terryjreedy
terryjreedy commented May 6, 2024
View reviewed changes
Comment thread Misc/NEWS.d/next/IDLE/2018-09-23-01-36-39.bpo-34774.VeM-X-.rst Outdated
@terryjreedy terryjreedy changed the title gh-78955: Use user-selected color theme for Help => IDLE Help. gh-78955: Use user-selected color theme for Help => IDLE Doc May 6, 2024
@terryjreedy

terryjreedy commented May 6, 2024

Copy link
Copy Markdown
Member Author

I removed the border as it is fixed black. I changed the pre block background to the text selectbackground. Possibly confusing, but there is currently no way to get tk colors as rgb tuple that I know of.

@terryjreedy terryjreedy merged commit 7758be4 into python:main May 6, 2024
@miss-islington-app

miss-islington-app Bot commented May 6, 2024

Copy link
Copy Markdown

Thanks @terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 6, 2024
@terryjreedy @miss-islington
pythongh-78955: Use user-selected color theme for Help => IDLE Doc (p…
2ba1a0d 
…ythonGH-9502)

(cherry picked from commit 7758be4)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
@bedevere-app

bedevere-app Bot commented May 6, 2024

Copy link
Copy Markdown

GH-118632 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label May 6, 2024
@terryjreedy terryjreedy deleted the help_colors branch May 6, 2024 07:56
terryjreedy added a commit that referenced this pull request May 6, 2024
@miss-islington @terryjreedy
[3.12] gh-78955: Use user-selected color theme for Help => IDLE Doc (G…
6abf840 
…H-9502) (#118632)

gh-78955: Use user-selected color theme for Help => IDLE Doc (GH-9502)
(cherry picked from commit 7758be4)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
@terryjreedy @SonicField
pythongh-78955: Use user-selected color theme for Help => IDLE Doc (p…
587a9ad 
…ython#9502)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@terryjreedy terryjreedy

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.