Skip to content

gh-95882: fix regression in the traceback of exceptions propagated from inside a contextlib context manager #95883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 15 commits into from
Jan 3, 2023
Merged

gh-95882: fix regression in the traceback of exceptions propagated from inside a contextlib context manager #95883

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8110f28
gh-95882 fix traceback of exceptions propagated from inside a context…
graingert Aug 11, 2022
3454e86
Merge branch 'main' into resolve-differences-between-asynccontextmana…
graingert Aug 11, 2022
5171ed7
Merge branch 'main' into resolve-differences-between-asynccontextmana…
graingert Aug 11, 2022
7f448d8
📜🤖 Added by blurb_it.
blurb-it[bot] Aug 11, 2022
25d3ee0
Update test_contextlib_async.py
graingert Aug 11, 2022
2990340
Merge branch 'main' into resolve-differences-between-asynccontextmana…
graingert Aug 11, 2022
adf2bf3
test for the Stop(Async)Iteration case
graingert Aug 11, 2022
0c9ef8b
Update Lib/contextlib.py
graingert Aug 11, 2022
cf3bcad
get rid of that extra yield frame from the traceback
graingert Aug 11, 2022
d448aaf
and fix it for contextlib.contextmanager
graingert Aug 11, 2022
7904e4b
Update Misc/NEWS.d/next/Library/2022-08-11-10-02-19.gh-issue-95882.Fs…
graingert Aug 11, 2022
b6c1f6e
this PR gets the ACK
graingert Aug 11, 2022
d8800cd
Update Misc/NEWS.d/next/Library/2022-08-11-10-02-19.gh-issue-95882.Fs…
graingert Aug 11, 2022
d4e0f2e
Merge branch 'main' into resolve-differences-between-asynccontextmana…
graingert Dec 20, 2022
8f785e9
Merge branch 'main' into resolve-differences-between-asynccontextmana…
iritkatriel Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
and fix it for contextlib.contextmanager
  • Loading branch information
@graingert
graingert committed Aug 11, 2022
commit d448aaf671b5a6f9be794d8945a9d125e62b5f2a
2 changes: 1 addition & 1 deletion Lib/contextlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def __exit__(self, typ, value, traceback):
isinstance(value, StopIteration)
and exc.__cause__ is value
):
exc.__traceback__ = traceback
value.__traceback__ = traceback
return False
raise
except BaseException as exc:
Expand Down