Skip to content

[3.7] bpo-34783: Fix test_nonexisting_script() (GH-9896) #9902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 1 commit into from
Oct 15, 2018
Merged

[3.7] bpo-34783: Fix test_nonexisting_script() (GH-9896) #9902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
bpo-34783: Fix test_nonexisting_script() (GH-9896) 
Fix test_cmd_line_script.test_nonexisting_script(): the test must not
rely on sys.executable, since main.c uses config->program which can
be different than sys.executable in many cases (for example, on macOS
when using the framework).
(cherry picked from commit ea75187)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
  • Loading branch information
@vstinner @miss-islington
vstinner authored and miss-islington committed Oct 15, 2018
commit 9ee6d26bff1c978cd711ec09e875a0b9f484050d
9 changes: 1 addition & 8 deletions Lib/test/test_cmd_line_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,26 +630,19 @@ def test_consistent_sys_path_for_module_execution(self):
traceback_lines = stderr.decode().splitlines()
self.assertIn("No module named script_pkg", traceback_lines[-1])

@unittest.skipIf(sys.platform == 'darwin' and sys._framework,
"test not valid for macOS framework builds")
def test_nonexisting_script(self):
# bpo-34783: "./python script.py" must not crash
# if the script file doesn't exist.
# (Skip test for macOS framework builds because sys.excutable name
# is not the actual Python executable file name.
script = 'nonexistingscript.py'
self.assertFalse(os.path.exists(script))
# Only test the base name, since the error message can use
# a relative path, whereas sys.executable can be an asolution path.
program = os.path.basename(sys.executable)

proc = spawn_python(script, text=True,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE)
out, err = proc.communicate()
# "./python" must be in the error message:
# "./python: can't open file (...)"
self.assertIn(program, err)
self.assertIn(": can't open file ", err)
self.assertNotEqual(proc.returncode, 0)


Expand Down