Skip to content

Speed up import time by deferring inspect #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaraco merged 4 commits into from
Aug 20, 2024
+3 −1
Merged

Speed up import time by deferring inspect #499

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e66fbc
Defer import inspect
danielhollas Aug 5, 2024
debb516
Don't use global var
danielhollas Aug 20, 2024
e99c105
Restore single-expression logic.
jaraco Aug 20, 2024
a7aaf72
Use third-person imperative voice and link to issue in comment.
jaraco Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion importlib_metadata/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import zipp
import email
import types
import inspect
import pathlib
import operator
import textwrap
Expand Down Expand Up @@ -1089,6 +1088,9 @@ def _get_toplevel_name(name: PackagePath) -> str:
>>> _get_toplevel_name(PackagePath('foo.dist-info'))
'foo.dist-info'
"""
# Defer import of inspect for performance (python/cpython#118761)
import inspect

return _topmost(name) or (
# python/typeshed#10328
inspect.getmodulename(name) # type: ignore
Expand Down