Proposed small tweaks to the text of PEP 561#467
Merged
Conversation
emmatyping
approved these changes
Nov 13, 2017
emmatyping
left a comment
emmatyping
left a comment
Member
There was a problem hiding this comment.
These changes look good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ethanhs Here are some small tweaks to your PEP 561, mostly to clarify a few things that confused me on initial reading. (E.g. when I saw a key
'pkg'in some example code I wasn't sure if it was a fixed key or simply an example name -- I changed this to'foopkg'everywhere.