Skip to content

Fix add_to_pydotorg session cleanup calls #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 1 commit into from
Jun 15, 2026
Merged

Fix add_to_pydotorg session cleanup calls #411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def post_object(base_url: str, objtype: str, datadict: dict[str, Any]) -> int:

def delete_object(base_url: str, objtype: str, pk: int) -> None:
"""Delete an existing API object."""
resp = requests.delete(base_url + f"downloads/{objtype}/{pk}/", headers=headers)
resp = session.delete(f"{base_url}downloads/{objtype}/{pk}/")
if resp.status_code != 204:
raise RuntimeError(f"Deleting {objtype} {pk} failed: {resp.status_code}")

Expand Down
22 changes: 20 additions & 2 deletions tests/test_add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
from typing import Any

import pytest
import requests
from pyfakefs.fake_filesystem import FakeFilesystem

os.environ["AUTH_INFO"] = "test_username:test_api_key"
Expand Down Expand Up @@ -87,14 +86,33 @@ class Response:
def fake_post(*args: Any, **kwargs: Any) -> Response:
return Response()

monkeypatch.setattr(requests, "post", fake_post)
monkeypatch.setattr(add_to_pydotorg.session, "post", fake_post)

with pytest.raises(RuntimeError, match="validation failed"):
add_to_pydotorg.post_object(
"https://example.invalid/api/v1/", "release_file", {"slug": "bad"}
)


def test_delete_object_uses_session(monkeypatch: pytest.MonkeyPatch) -> None:
class Response:
status_code = 204

calls: list[str] = []

def fake_delete(url: str) -> Response:
calls.append(url)
return Response()

monkeypatch.setattr(add_to_pydotorg.session, "delete", fake_delete)

add_to_pydotorg.delete_object(
"https://example.invalid/api/v1/", "release_file", 123
)

assert calls == ["https://example.invalid/api/v1/downloads/release_file/123/"]


def test_create_release_files_cleans_up_created_rows(
monkeypatch: pytest.MonkeyPatch,
) -> None:
Expand Down
Loading