Use TypeAlias for types in sqlite3.dbapi2#9158
Conversation
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
Btw, I've found many more missing type aliases in other modules via my custom query. Are you interested in annotated them? |
|
What benefits does this PR bring? There are some differing opinions on exactly when |
|
I've just seen @srittau's comment on his vision of I see Consider these lines: x = 1
def some(): ...
class T: ...
y = x
other = some
T1 = T
T2: TypeAlias = THere we can notice that But, But, feel free to close if this is not something you want, I don't have a strong opinion. |
|
I'd also be hesitant to make a change here unless there's a clear problem being fixed. |
|
Let's close this for now |
No description provided.